Skip to content

RAG Toolkit: Out of KB questions [GSK-3372]#1861

Merged
JiaenLiu merged 13 commits intomainfrom
task/out-of-kb-questions-gsk-3372
Apr 8, 2024
Merged

RAG Toolkit: Out of KB questions [GSK-3372]#1861
JiaenLiu merged 13 commits intomainfrom
task/out-of-kb-questions-gsk-3372

Conversation

@JiaenLiu
Copy link
Copy Markdown
Contributor

@JiaenLiu JiaenLiu commented Mar 25, 2024

Description

First prototype of out of knowledge base question

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@JiaenLiu JiaenLiu requested a review from mattbit March 25, 2024 13:15
@JiaenLiu JiaenLiu self-assigned this Mar 25, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Mar 25, 2024

GSK-3372 First prototype of out of knowledge base questions

mattbit
mattbit previously requested changes Mar 25, 2024
View reviewed changes
Comment thread giskard/rag/metrics/__init__.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
Comment thread tests/rag/test_question_generators.py Outdated
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
@mattbit mattbit changed the title Task/out of kb questions gsk 3372 RAG Toolkit: Out of KB questions [GSK-3372] Mar 25, 2024
@JiaenLiu JiaenLiu requested a review from mattbit March 25, 2024 15:50
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
pierlj
pierlj reviewed Apr 2, 2024
View reviewed changes
Comment thread giskard/rag/question_generators/ookb_questions.py Outdated
@JiaenLiu JiaenLiu requested a review from pierlj April 2, 2024 13:43
@JiaenLiu JiaenLiu enabled auto-merge April 4, 2024 14:05
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pierlj pierlj dismissed mattbit’s stale review April 8, 2024 13:40

Changes were adressed

@JiaenLiu JiaenLiu merged commit 3bea570 into main Apr 8, 2024
@JiaenLiu JiaenLiu deleted the task/out-of-kb-questions-gsk-3372 branch April 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierlj pierlj pierlj approved these changes

@mattbit mattbit Awaiting requested review from mattbit

Assignees

@JiaenLiu JiaenLiu

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JiaenLiu @mattbit @pierlj