Skip to content

fix(giskard-agents): use jinja2 sandboxed environment to prevent template injection [ENG-1486] #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattbit merged 3 commits into from
Mar 25, 2026
Merged

fix(giskard-agents): use jinja2 sandboxed environment to prevent template injection [ENG-1486] #2332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3e7cb0
fix: use jinja2 sandboxed environment to prevent template injection […
mattbit Mar 24, 2026
7b2a133
Merge branch 'main' into fix/jinja-sanboxed-environment
mattbit Mar 25, 2026
afe574d
Merge branch 'main' into fix/jinja-sanboxed-environment
mattbit Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions libs/giskard-agents/src/giskard/agents/templates/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
from pathlib import Path
from typing import Any, Protocol, runtime_checkable

from jinja2 import BaseLoader, Environment, StrictUndefined, nodes
from jinja2 import BaseLoader, StrictUndefined, nodes
from jinja2.exceptions import TemplateNotFound
from jinja2.ext import Extension
from jinja2.loaders import FileSystemLoader, PrefixLoader
from jinja2.sandbox import SandboxedEnvironment
from pydantic import BaseModel

from ..chat import Message, Role
Expand Down Expand Up @@ -34,7 +35,7 @@ def _finalize_value(value: Any) -> Any:
return value


_inline_env = Environment(
_inline_env = SandboxedEnvironment(
trim_blocks=True,
lstrip_blocks=True,
keep_trailing_newline=True,
Expand Down Expand Up @@ -88,9 +89,9 @@ def get_loader(self, template: str) -> tuple[BaseLoader, str]:
return loader, name


def create_message_environment(loader_mapping: dict[str, Path]) -> Environment:
def create_message_environment(loader_mapping: dict[str, Path]) -> SandboxedEnvironment:
"""Create a Jinja2 environment with MessageExtension."""
return Environment(
return SandboxedEnvironment(
loader=PromptsLoader(
{
namespace: FileSystemLoader(path)
Expand Down