docs(contributing): align guide with repo and fix links#2344
Merged
kevinmessiaen merged 7 commits intomainfrom Apr 3, 2026
Merged
docs(contributing): align guide with repo and fix links#2344kevinmessiaen merged 7 commits intomainfrom
kevinmessiaen merged 7 commits intomainfrom
Conversation
Member
kevinmessiaen
commented
Mar 27, 2026
- Document uv workspace, Ruff, basedpyright, pre-commit, and make check/help
- Point code of conduct to local CODE_OF_CONDUCT.md
- Link built-in check contributions to giskard-checks README section
- Clarify Issues wording, docs phrasing, and Hugging Face attribution
- Document uv workspace, Ruff, basedpyright, pre-commit, and make check/help - Point code of conduct to local CODE_OF_CONDUCT.md - Link built-in check contributions to giskard-checks README section - Clarify Issues wording, docs phrasing, and Hugging Face attribution Made-with: Cursor
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CONTRIBUTING.md file to reflect the project's migration to a uv workspace and Python 3.12+. It includes updated setup instructions, new make targets, and improved documentation for contributing custom checks. A review comment suggests formatting the style guide introduction as a list to improve readability for new contributors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.