Skip to content

fix(deps): declare regex on giskard-checks#2405

Merged
kevinmessiaen merged 2 commits intomainfrom
chore/regex-giskard-checks-dependency
Apr 17, 2026
Merged

fix(deps): declare regex on giskard-checks#2405
kevinmessiaen merged 2 commits intomainfrom
chore/regex-giskard-checks-dependency

Conversation

@kevinmessiaen
Copy link
Copy Markdown
Member

Description

Move the regex PyPI dependency from the root giskard metapackage to giskard-checks, where it is imported (text_matching.py / regex matching check). The root package still pulls it in transitively via giskard-checks. uv.lock was refreshed.

Related Issue

N/A

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in NumPy format for all the methods and classes that I created or modified.
  • I've updated the uv.lock running uv lock (only applicable when pyproject.toml has been
    modified)

Made with Cursor

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the regex dependency from the root pyproject.toml to the libs/giskard-checks package. While the pyproject.toml changes are correct, the uv.lock file appears to have been updated incorrectly, with the dependency being added to the wrong package block. It is recommended to regenerate the lock file to ensure it correctly reflects the dependency tree.

Comment thread uv.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant