fix(deps): declare regex on giskard-checks#2405
Merged
kevinmessiaen merged 2 commits intomainfrom Apr 17, 2026
Merged
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the regex dependency from the root pyproject.toml to the libs/giskard-checks package. While the pyproject.toml changes are correct, the uv.lock file appears to have been updated incorrectly, with the dependency being added to the wrong package block. It is recommended to regenerate the lock file to ensure it correctly reflects the dependency tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the
regexPyPI dependency from the rootgiskardmetapackage togiskard-checks, where it is imported (text_matching.py/ regex matching check). The root package still pulls it in transitively viagiskard-checks.uv.lockwas refreshed.Related Issue
N/A
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.uv.lockrunninguv lock(only applicable whenpyproject.tomlhas beenmodified)
Made with Cursor