KAFKA-20366: Add syntax highlighting in security docs#21965
KAFKA-20366: Add syntax highlighting in security docs#21965mimaison merged 6 commits intoapache:trunkfrom
Conversation
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a couple of comments
| 1. Add a JAAS config file with a client login section named `KafkaClient`. Configure a login module in `KafkaClient` for the selected mechanism as described in the examples for setting up GSSAPI (Kerberos), PLAIN, SCRAM, or non-production/production OAUTHBEARER. For example, GSSAPI credentials may be configured as: | ||
|
|
||
| ``` | ||
| ```text |
There was a problem hiding this comment.
Is there any value in setting the language to test?
There was a problem hiding this comment.
It's to enable the copy icon, and to keep it consistently handled by Hugo's code block render hook.
| user_admin="admin-secret" \ | ||
| user_alice="alice-secret"; | ||
|
|
||
| ```properties |
There was a problem hiding this comment.
Is properties the correct language? According to https://gohugo.io/content-management/syntax-highlighting/#languages I see it called java-properties
There was a problem hiding this comment.
When I built the Kafka website locally, it rendered with highlighting, so I didn't notice the issue.
As you pointed out, java-properties is the officially documented identifier in Hugo, so I'll update it accordingly.
|
I'd recommend doing it one folder at a time. It does not make a lot of sense to do Streams and Security in the same PR. |
Agreed. I'll revert the Streams changes from this PR and update the title and description accordingly. I'll open a separate PR for Streams afterward. Thanks for the review! |
491700f to
596075f
Compare
Uh oh!
There was an error while loading. Please reload this page.