feat: Declare types in AGENTS.md for better structure and clarity#396
Merged
jirispilka merged 1 commit intomasterfrom Jan 21, 2026
Merged
feat: Declare types in AGENTS.md for better structure and clarity#396jirispilka merged 1 commit intomasterfrom
jirispilka merged 1 commit intomasterfrom
Conversation
MQ37
added a commit
that referenced
this pull request
Jan 20, 2026
Previously, task mode execution (executeToolAndUpdateTask) rejected all internal tools, only allowing actor tools. This was inconsistent with tools like call-actor that declare taskSupport: 'optional'. Changes: - Remove hard rejection of internal tools in task mode - Add execution path for internal tools in task mode - Pass userRentedActorIds to task execution context - Add integration test for call-actor in task mode This fixes the architectural issue identified in PR #396 review where centralized skyfire validation worked but internal tools couldn't reach that code path due to early rejection.
MQ37
added a commit
that referenced
this pull request
Jan 20, 2026
* Initial plan * Centralize skyfire validation in MCP server dispatcher Co-authored-by: MQ37 <29043708+MQ37@users.noreply.github.com> * fix: enable task mode support for internal tools with taskSupport Previously, task mode execution (executeToolAndUpdateTask) rejected all internal tools, only allowing actor tools. This was inconsistent with tools like call-actor that declare taskSupport: 'optional'. Changes: - Remove hard rejection of internal tools in task mode - Add execution path for internal tools in task mode - Pass userRentedActorIds to task execution context - Add integration test for call-actor in task mode This fixes the architectural issue identified in PR #396 review where centralized skyfire validation worked but internal tools couldn't reach that code path due to early rejection. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MQ37 <29043708+MQ37@users.noreply.github.com> Co-authored-by: MQ37 <themq37@gmail.com>
MQ37
added a commit
that referenced
this pull request
Jan 20, 2026
* fix: skyfire parameter injection and missing tool registration Fixed critical bug where 8 out of 11 skyfire-enabled tools were missing the required `skyfire-pay-id` parameter in their input schemas. Refactored Skyfire integration to eliminate ~180 lines of duplicated code. Critical fixes: - Schema injection now uses SKYFIRE_ENABLED_TOOLS Set instead of hardcoded list - Added missing abortActorRun tool to runs category Changes: - Created src/utils/skyfire.ts with reusable helper functions - Refactored 13 code locations to use helpers - Added skyfire mode detection via ?payment=skyfire query parameter - Added integration test for schema injection - Updated test helpers and documentation Tools affected: call-actor, get-actor-output, get-actor-run, get-actor-log, abort-actor-run, get-dataset, get-dataset-items, get-dataset-schema, get-key-value-store, get-key-value-store-keys, get-key-value-store-record Files: 13 files changed, 286 insertions(+), 92 deletions(-) * Centralize skyfire pay ID validation in tool dispatcher (#395) * Initial plan * Centralize skyfire validation in MCP server dispatcher Co-authored-by: MQ37 <29043708+MQ37@users.noreply.github.com> * fix: enable task mode support for internal tools with taskSupport Previously, task mode execution (executeToolAndUpdateTask) rejected all internal tools, only allowing actor tools. This was inconsistent with tools like call-actor that declare taskSupport: 'optional'. Changes: - Remove hard rejection of internal tools in task mode - Add execution path for internal tools in task mode - Pass userRentedActorIds to task execution context - Add integration test for call-actor in task mode This fixes the architectural issue identified in PR #396 review where centralized skyfire validation worked but internal tools couldn't reach that code path due to early rejection. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MQ37 <29043708+MQ37@users.noreply.github.com> Co-authored-by: MQ37 <themq37@gmail.com> * refactor: move createApifyClientWithSkyfireSupport to apify-clients.ts * fix compiler and lint issues after merge --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: MQ37 <29043708+MQ37@users.noreply.github.com>
MQ37
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.