Skip to content

fix: Move streamable HTTP transport from /mcp to root /#529

Merged
jirispilka merged 6 commits intomasterfrom
copilot/move-streamable-transport-to-root
Mar 6, 2026
Merged

fix: Move streamable HTTP transport from /mcp to root /#529
jirispilka merged 6 commits intomasterfrom
copilot/move-streamable-transport-to-root

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

  • Update Routes.MCP = '/mcp' to '/' in src/actor/const.ts; remove now-redundant Routes.ROOT
  • In src/actor/server.ts: remove old GET / info-response handler; remove GET Routes.MCP (405) handler per review; replace Routes.ROOT with Routes.MCP in HEAD handler; remove unused HEADER_READINESS_PROBE and getActorRunData imports
  • Update DEVELOPMENT.md: replace /mcp?ui=openai with /?ui=openai in all endpoint references
  • Revert MCP_STREAMABLE_ENDPOINT in src/const.ts back to '/mcp' — this constant is used for third-party Actor endpoint discovery, not our own server routing
  • Lint clean, all 402 unit tests pass
Original prompt

This section details on the original issue you should resolve

<issue_title>Dev server - ,ove streamable transport from /mcp to root /</issue_title>
<issue_description>In src/actor/server.ts we serve streamable transport from the /mcp route.

At root / we return 200. The reason is historical, as this file was used as an Actor.

Going forward, we should serve streamable transport directly from root to remove confusion for different setups (for staging and production, streamable transport is directly at root).

Note that src/server_card.ts already declares endpoint: '/', so the server card is already inconsistent with the actual /mcp route. Moving to root aligns them.

  • Move POST /mcp, GET /mcp, DELETE /mcp handlers to POST /, GET /, DELETE /
  • Update MCP_STREAMABLE_ENDPOINT = '/mcp' in src/const.ts
  • Update getHelpMessage in src/actor/const.ts which references /mcp</issue_description>

<agent_instructions>Keep the solution minimal, do not put anything extra, do not remove comments etc</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jirispilka <19406805+jirispilka@users.noreply.github.com>
Copilot AI changed the title [WIP] Move streamable transport from /mcp to root / Move streamable HTTP transport from /mcp to root / Mar 4, 2026
@github-actions github-actions Bot added the t-ai Issues owned by the AI team. label Mar 4, 2026
Copy link
Copy Markdown
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you need to update CLAUDE.md or DEVELOPMENT.md with this change so that developers are aware of that!

Comment thread src/actor/server.ts Outdated
@jirispilka jirispilka changed the title Move streamable HTTP transport from /mcp to root / fix: Move streamable HTTP transport from /mcp to root / Mar 4, 2026
Co-authored-by: jirispilka <19406805+jirispilka@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot you need to update CLAUDE.md or DEVELOPMENT.md with this change so that developers are aware of that!

Done in fa1a4f2 — updated all /mcp?ui=openai endpoint references in DEVELOPMENT.md to /?ui=openai.

@jirispilka jirispilka self-requested a review March 4, 2026 10:21
Copy link
Copy Markdown
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot buddy, you have changed MCP_STREAMABLE_ENDPOINT that is used for a different purpose and changing this will break other parts of code.

Let's fix it, please think before you do changes

Co-authored-by: jirispilka <19406805+jirispilka@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot buddy, you have changed MCP_STREAMABLE_ENDPOINT that is used for a different purpose and changing this will break other parts of code.

Let's fix it, please think before you do changes

Fixed in f9cdd4a — reverted MCP_STREAMABLE_ENDPOINT in src/const.ts back to '/mcp'. That constant is used by src/mcp/actors.ts for third-party Actor endpoint discovery, not for our dev server routing (which is controlled by Routes.MCP in src/actor/const.ts).

Copy link
Copy Markdown
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, but it took more turn around than necessary

@jirispilka jirispilka marked this pull request as ready for review March 4, 2026 10:32
@jirispilka jirispilka requested a review from MQ37 March 4, 2026 10:32
@jirispilka jirispilka merged commit 6e408fd into master Mar 6, 2026
10 checks passed
@jirispilka jirispilka deleted the copilot/move-streamable-transport-to-root branch March 6, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev server - move streamable transport from /mcp to root /

4 participants