fix: Add actor id data to actor info#687
Conversation
There was a problem hiding this comment.
LGTM — clean, consistent addition of actor ID across type, schema, and implementation.
Extended reasoning...
Overview
Adds id: string to StructuredActorCard (types.ts), the actorInfoSchema JSON Schema (structured_output_schemas.ts), and the formatActorToStructuredCard return value (actor_card.ts). Three-file change, all aligned.
Security risks
None. This is a read-only data field surfaced from the existing actor.id property already present on Actor | ActorStoreList from the Apify client. No auth, crypto, or permissions code is touched.
Level of scrutiny
Low. The change is purely additive and mechanical — a new string field propagated through type → schema → formatter. All three sites are consistent with each other. The actor.id source is reliable (it comes directly from the Apify API response object).
Other factors
The pre-existing bug (isDeprecated missing from required[]) has zero runtime impact and predates this PR. The PR itself is correct. No prior reviews exist on this PR.
jirispilka
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I would fix the suggestion from Claude.
As the claude puts it :)
"While this predates the PR, it was a natural opportunity to fix since the required array was already modified to add 'id'."
Pre-approving
|
@baldasseva please merge it before this refactor: #694 I don't think there will be conflicts but it is better to merge this pr and deal with any possible conflict in the #694 |
The chat reponse in console has links that point to apify.com. If I don't receive ids in any way, I'm afraid I can't do anything.
So I want to receive actor ids in the structured data, then prompt the console AI chat to use that id to generate the links and ignore the apify.com url that is sent. I hope this will work!