Skip to content

Add expect-error input to force PR check green on expected failure #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 22 commits into from
Aug 16, 2022
Merged

Add expect-error input to force PR check green on expected failure #1177

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b7d4497
Add expect-error to expected failure job check
angelapwen Aug 12, 2022
4fb1cdc
Remove "failure expected" in PR check name
angelapwen Aug 12, 2022
c756bae
Update `expect-errors` input description
angelapwen Aug 12, 2022
59d39e3
Add double quotes to input description
angelapwen Aug 12, 2022
f5a4ea9
Throw error if caller isn't codeql-action
angelapwen Aug 15, 2022
14763b6
Merge remote-tracking branch 'origin/main' into angelapwen/expect-err…
angelapwen Aug 15, 2022
e31c33d
Fix string equality comparison
angelapwen Aug 15, 2022
46f3540
Move error throwing location
angelapwen Aug 15, 2022
3606edb
Add print debug messages
angelapwen Aug 16, 2022
334b121
Fix expected repo URL
angelapwen Aug 16, 2022
65fcacd
Set failure if input is set incorrectly
angelapwen Aug 16, 2022
3d8828a
Update `expect-errors` input description
angelapwen Aug 16, 2022
6be3892
Address comments, throw failure if expected and didn't fail
angelapwen Aug 16, 2022
0736537
Merge remote-tracking branch 'origin/main' into angelapwen/expect-err…
angelapwen Aug 16, 2022
1e1da28
Set failure in other spot for expect-error but not thrown
angelapwen Aug 16, 2022
66bfa45
Test removing runWrapper's failure
angelapwen Aug 16, 2022
70d3299
Check error input is not default value
angelapwen Aug 16, 2022
41f86d9
Test remove runWrapper setting failure
angelapwen Aug 16, 2022
5aec66f
Test run where error expected but not received
angelapwen Aug 16, 2022
98d4d17
Fail with ram:1 in failure workflow
angelapwen Aug 16, 2022
f8f36a7
Comment fixups
angelapwen Aug 16, 2022
b67600f
Remove extraneous log lines
angelapwen Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analyze/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ inputs:
matrix:
default: ${{ toJson(matrix) }}
expect-error:
description: For PR checks. If true, the Action will not set Actions status to failure.
description: "[Internal] If true, the Action will not set Actions status to failure."
Comment thread
angelapwen marked this conversation as resolved.
Outdated
required: false
default: "false"
outputs:
Expand Down
19 changes: 18 additions & 1 deletion lib/actions-util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/actions-util.js.map
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 11 additions & 2 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading