Fix stale resource content in Resources panel#1267
Open
nicbarrett wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix stale resource content in Resources panel#1267nicbarrett wants to merge 1 commit intomodelcontextprotocol:mainfrom
nicbarrett wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
1e26f3f to
da383be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The Resources panel could show stale content from a previously read resource when switching back to a resource that had already been cached. The selected row and heading updated, but the detail pane could continue showing a different resource's payload.
Root cause
resourceContentstring instead of content derived fromselectedResource.urireadResource()returned early for cached resources, so selecting an already-read resource did not repopulate the visible paneFix
resourceContentMap[selectedResource.uri]forceflag toreadResource()Validation
npm test --workspace=client -- --runInBand App.resources.test.tsx ResourcesTab.test.tsxCloses #1266.