[FIXED] Check of maxpayload could be bypassed if size overruns int32#1053
Merged
[FIXED] Check of maxpayload could be bypassed if size overruns int32#1053
Conversation
Member
derekcollison
left a comment
There was a problem hiding this comment.
Checking on int32 -> int64 cast removing negative bit.
Also should credit TL for report.
One could craft a PUB protocol to cause server to panic. This can happen if the size in the PUB protocol overruns an int32. (note that if authorization is enabled, the user would need to authenticate first, limiting the impact). Thank you to Aviv Sasson and Ariel Zelivansky from Twistlock for the security report! Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Member
Author
|
Added to commit log reference to people from Twistlock that reported the security issue. |
derekcollison
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One could craft a PUB protocol to cause server to panic. This can
happen if the size in the PUB protocol overruns an int32.
(note that if authorization is enabled, the user would need to
authenticate first, limiting the impact).
Thank you to Aviv Sasson and Ariel Zelivansky from Twistlock
for the security report!
Signed-off-by: Ivan Kozlovic ivan@synadia.com