Fix failing stylelint CI workflow#2988
Fix failing stylelint CI workflow#2988llastflowers merged 5 commits intodependabot/npm_and_yarn/all-1b87d1002afrom
Conversation
Bumps the all group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` | | [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` | | [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` | | [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` | | [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` | | [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` | | [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` | Updates `@primer/primitives` from 11.3.2 to 11.4.0 - [Release notes](https://github.com/primer/primitives/releases) - [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md) - [Commits](primer/primitives@v11.3.2...v11.4.0) Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2 - [Release notes](https://github.com/primer/stylelint-config/releases) - [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md) - [Commits](primer/stylelint-config@v13.4.1...v13.4.2) Updates `autoprefixer` from 10.4.23 to 10.4.24 - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](postcss/autoprefixer@10.4.23...10.4.24) Updates `eslint` from 9.39.2 to 10.0.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.0) Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0) Updates `globby` from 16.1.0 to 16.1.1 - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](sindresorhus/globby@v16.1.0...v16.1.1) Updates `semver` from 7.7.3 to 7.7.4 - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.7.3...v7.7.4) Updates `stylelint` from 17.0.0 to 17.3.0 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@17.0.0...17.3.0) --- updated-dependencies: - dependency-name: "@primer/primitives" dependency-version: 11.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: "@primer/stylelint-config" dependency-version: 13.4.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: autoprefixer dependency-version: 10.4.24 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: all - dependency-name: eslint-plugin-jest dependency-version: 29.15.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: globby dependency-version: 16.1.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: semver dependency-version: 7.7.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: stylelint dependency-version: 17.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com>
|
1076afb to
3e9adc1
Compare
…x-stylelint-workflow
|
@copilot are you "fixing" this PR by just reverting all of the version updates that the original PR was intended to add? |
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
No — the Dependabot version updates in |
@copilot what's with all the changes in |
Those
My only commits are |
#2989) * Initial plan * Fix stylelint CI failure: update package-lock.json to use stylelint@17.4.0 Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
04db7f4
into
dependabot/npm_and_yarn/all-1b87d1002a
* Bump the all group across 1 directory with 8 updates Bumps the all group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` | | [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` | | [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` | | [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` | | [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` | | [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` | | [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` | Updates `@primer/primitives` from 11.3.2 to 11.4.0 - [Release notes](https://github.com/primer/primitives/releases) - [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md) - [Commits](primer/primitives@v11.3.2...v11.4.0) Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2 - [Release notes](https://github.com/primer/stylelint-config/releases) - [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md) - [Commits](primer/stylelint-config@v13.4.1...v13.4.2) Updates `autoprefixer` from 10.4.23 to 10.4.24 - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](postcss/autoprefixer@10.4.23...10.4.24) Updates `eslint` from 9.39.2 to 10.0.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.0) Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0) Updates `globby` from 16.1.0 to 16.1.1 - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](sindresorhus/globby@v16.1.0...v16.1.1) Updates `semver` from 7.7.3 to 7.7.4 - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.7.3...v7.7.4) Updates `stylelint` from 17.0.0 to 17.3.0 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@17.0.0...17.3.0) --- updated-dependencies: - dependency-name: "@primer/primitives" dependency-version: 11.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: "@primer/stylelint-config" dependency-version: 13.4.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: autoprefixer dependency-version: 10.4.24 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: all - dependency-name: eslint-plugin-jest dependency-version: 29.15.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: globby dependency-version: 16.1.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: semver dependency-version: 7.7.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: stylelint dependency-version: 17.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com> * Fix failing stylelint CI workflow (#2988) * Bump the all group across 1 directory with 8 updates Bumps the all group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` | | [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` | | [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` | | [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` | | [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` | | [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` | | [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` | Updates `@primer/primitives` from 11.3.2 to 11.4.0 - [Release notes](https://github.com/primer/primitives/releases) - [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md) - [Commits](primer/primitives@v11.3.2...v11.4.0) Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2 - [Release notes](https://github.com/primer/stylelint-config/releases) - [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md) - [Commits](primer/stylelint-config@v13.4.1...v13.4.2) Updates `autoprefixer` from 10.4.23 to 10.4.24 - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md) - [Commits](postcss/autoprefixer@10.4.23...10.4.24) Updates `eslint` from 9.39.2 to 10.0.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.0) Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0) Updates `globby` from 16.1.0 to 16.1.1 - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](sindresorhus/globby@v16.1.0...v16.1.1) Updates `semver` from 7.7.3 to 7.7.4 - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.7.3...v7.7.4) Updates `stylelint` from 17.0.0 to 17.3.0 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@17.0.0...17.3.0) --- updated-dependencies: - dependency-name: "@primer/primitives" dependency-version: 11.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: "@primer/stylelint-config" dependency-version: 13.4.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: autoprefixer dependency-version: 10.4.24 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: all - dependency-name: eslint-plugin-jest dependency-version: 29.15.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all - dependency-name: globby dependency-version: 16.1.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: semver dependency-version: 7.7.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: stylelint dependency-version: 17.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com> * Initial plan * Fix all stylelint errors causing CI workflow failure Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> * Fix stylelint CI failure caused by missing `balanced-match` dependency (#2989) * Initial plan * Fix stylelint CI failure: update package-lock.json to use stylelint@17.4.0 Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Brittany L. Houtz <55068883+llastflowers@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Brittany L. Houtz <55068883+llastflowers@users.noreply.github.com>
What are you trying to accomplish?
Fix 11+ stylelint errors causing the CI
stylelintworkflow to fail (job #64635067944).What approach did you choose and why?
Addressed each rule violation at the source:
nesting-selector-no-missing-scoping-root— Stylelint incorrectly flags&inside@mixinbodies, which are valid (they resolve at@includetime). Added scopedstylelint-disable/enableblock comments around the offending mixins:src/support/mixins/misc.scss—double-caretmixinsrc/support/mixins/layout.scss—clearfixmixinproperty-no-deprecated(word-wrap→overflow-wrap) — Replaced deprecatedword-wrapwith the CSS standardoverflow-wrapacross:src/markdown/code.scss,src/markdown/markdown-body.scss,src/tooltips/tooltips.scsssrc/utilities/typography.scss— removed redundantword-wrapline sinceoverflow-wrapalready followed itproperty-no-deprecated(clip) — The visually-hiddenclip: rect(1px, 1px, 1px, 1px)pattern is used for accessibility and replacing it risks behavioral regressions. Added inline/* stylelint-disable-line property-no-deprecated */in:src/layout/app-frame.scss,src/utilities/visibility-display.scss--report-needless-disables— Removed staledeclaration-property-value-no-unknownfrom disable comments where the rule no longer fires:src/markdown/footnotes.scss,src/markdown/markdown-body.scss,src/navigation/sidenav.scsscolor-function-alias-notation— Replacedrgba()withrgb()insrc/marketing/buttons/button.scssWhat should reviewers focus on?
clipdeprecation is intentionally suppressed rather than replaced withclip-path: inset(50%)to avoid any risk to the established visually-hidden accessibility pattern. If the project wants to modernize this, it should be a separate deliberate change.word-wrap: break-word !importantfrom.wb-break-wordintypography.scssis acceptable —overflow-wrap: break-word !importantremains and is functionally equivalent in all supported browsers.Can these changes ship as is?
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.