Skip to content

Fix failing stylelint CI workflow#2988

Merged
llastflowers merged 5 commits intodependabot/npm_and_yarn/all-1b87d1002afrom
copilot/fix-stylelint-workflow
Feb 26, 2026
Merged

Fix failing stylelint CI workflow#2988
llastflowers merged 5 commits intodependabot/npm_and_yarn/all-1b87d1002afrom
copilot/fix-stylelint-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 26, 2026

What are you trying to accomplish?

Fix 11+ stylelint errors causing the CI stylelint workflow to fail (job #64635067944).

What approach did you choose and why?

Addressed each rule violation at the source:

  • nesting-selector-no-missing-scoping-root — Stylelint incorrectly flags & inside @mixin bodies, which are valid (they resolve at @include time). Added scoped stylelint-disable/enable block comments around the offending mixins:

    • src/support/mixins/misc.scssdouble-caret mixin
    • src/support/mixins/layout.scssclearfix mixin
  • property-no-deprecated (word-wrapoverflow-wrap) — Replaced deprecated word-wrap with the CSS standard overflow-wrap across:

    • src/markdown/code.scss, src/markdown/markdown-body.scss, src/tooltips/tooltips.scss
    • src/utilities/typography.scss — removed redundant word-wrap line since overflow-wrap already followed it
  • property-no-deprecated (clip) — The visually-hidden clip: rect(1px, 1px, 1px, 1px) pattern is used for accessibility and replacing it risks behavioral regressions. Added inline /* stylelint-disable-line property-no-deprecated */ in:

    • src/layout/app-frame.scss, src/utilities/visibility-display.scss
  • --report-needless-disables — Removed stale declaration-property-value-no-unknown from disable comments where the rule no longer fires:

    • src/markdown/footnotes.scss, src/markdown/markdown-body.scss, src/navigation/sidenav.scss
  • color-function-alias-notation — Replaced rgba() with rgb() in src/marketing/buttons/button.scss

What should reviewers focus on?

  • The clip deprecation is intentionally suppressed rather than replaced with clip-path: inset(50%) to avoid any risk to the established visually-hidden accessibility pattern. If the project wants to modernize this, it should be a separate deliberate change.
  • Confirm that removing word-wrap: break-word !important from .wb-break-word in typography.scss is acceptable — overflow-wrap: break-word !important remains and is functionally equivalent in all supported browsers.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢
Original prompt

Fix the failing GitHub Actions workflow stylelint
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 64635067944
Job URL: https://github.com/primer/css/actions/runs/22338064636/job/64635067944


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dependabot Bot and others added 2 commits February 24, 2026 05:32
Bumps the all group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` |
| [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` |
| [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` |
| [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` |
| [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` |
| [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` |
| [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` |
| [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` |



Updates `@primer/primitives` from 11.3.2 to 11.4.0
- [Release notes](https://github.com/primer/primitives/releases)
- [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md)
- [Commits](primer/primitives@v11.3.2...v11.4.0)

Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2
- [Release notes](https://github.com/primer/stylelint-config/releases)
- [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md)
- [Commits](primer/stylelint-config@v13.4.1...v13.4.2)

Updates `autoprefixer` from 10.4.23 to 10.4.24
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.23...10.4.24)

Updates `eslint` from 9.39.2 to 10.0.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.2...v10.0.0)

Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0)

Updates `globby` from 16.1.0 to 16.1.1
- [Release notes](https://github.com/sindresorhus/globby/releases)
- [Commits](sindresorhus/globby@v16.1.0...v16.1.1)

Updates `semver` from 7.7.3 to 7.7.4
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.7.3...v7.7.4)

Updates `stylelint` from 17.0.0 to 17.3.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@17.0.0...17.3.0)

---
updated-dependencies:
- dependency-name: "@primer/primitives"
  dependency-version: 11.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@primer/stylelint-config"
  dependency-version: 13.4.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: autoprefixer
  dependency-version: 10.4.24
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: eslint
  dependency-version: 10.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-jest
  dependency-version: 29.15.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: globby
  dependency-version: 16.1.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: semver
  dependency-version: 7.7.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: stylelint
  dependency-version: 17.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 26, 2026

⚠️ No Changeset found

Latest commit: 47be475

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/all-1b87d1002a branch from 1076afb to 3e9adc1 Compare February 26, 2026 20:48
@llastflowers
Copy link
Copy Markdown
Contributor

@copilot are you "fixing" this PR by just reverting all of the version updates that the original PR was intended to add?

Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
@github-actions github-actions Bot temporarily deployed to Storybook Preview February 26, 2026 20:55 Inactive
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow for stylelint Fix failing stylelint CI workflow Feb 26, 2026
Copilot AI requested a review from llastflowers February 26, 2026 20:56
@github-actions github-actions Bot temporarily deployed to Storybook Preview February 26, 2026 20:57 Inactive
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 26, 2026

@copilot are you "fixing" this PR by just reverting all of the version updates that the original PR was intended to add?

No — the Dependabot version updates in package.json and package-lock.json are fully preserved. The only changes in my commit are to 11 SCSS source files to fix the stylelint rule violations that were surfaced by the upgraded @primer/stylelint-config package (stricter rules like nesting-selector-no-missing-scoping-root, property-no-deprecated, color-function-alias-notation, and --report-needless-disables). Commit: 2bb518f

@llastflowers
Copy link
Copy Markdown
Contributor

@copilot are you "fixing" this PR by just reverting all of the version updates that the original PR was intended to add?

No — the Dependabot version updates in package.json and package-lock.json are fully preserved. The only changes in my commit are to 11 SCSS source files to fix the stylelint rule violations that were surfaced by the upgraded @primer/stylelint-config package (stricter rules like nesting-selector-no-missing-scoping-root, property-no-deprecated, color-function-alias-notation, and --report-needless-disables). Commit: 2bb518f

@copilot what's with all the changes in package-lock.json?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 26, 2026

@copilot are you "fixing" this PR by just reverting all of the version updates that the original PR was intended to add?

No — the Dependabot version updates in `package....

Those package-lock.json changes are not from me. Looking at the commit history:

  • The large package-lock.json diff (492 lines) is from the Dependabot commit 1076afb — the base branch dependabot/npm_and_yarn/all-1b87d1002a bumping 8 packages.
  • The smaller reconciliation diff (31 lines) is from the merge commit 26311a1, authored by you (@llastflowers), merging the Dependabot branch into this branch.

My only commits are 3ab0930 (empty plan) and 2bb518f (11 SCSS files only — zero changes to package.json or package-lock.json).

#2989)

* Initial plan

* Fix stylelint CI failure: update package-lock.json to use stylelint@17.4.0

Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
@llastflowers llastflowers marked this pull request as ready for review February 26, 2026 21:23
@llastflowers llastflowers requested review from a team as code owners February 26, 2026 21:23
@github-actions github-actions Bot temporarily deployed to Storybook Preview February 26, 2026 21:24 Inactive
@llastflowers llastflowers merged commit 04db7f4 into dependabot/npm_and_yarn/all-1b87d1002a Feb 26, 2026
14 checks passed
@llastflowers llastflowers deleted the copilot/fix-stylelint-workflow branch February 26, 2026 21:30
llastflowers added a commit that referenced this pull request Feb 26, 2026
* Bump the all group across 1 directory with 8 updates

Bumps the all group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` |
| [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` |
| [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` |
| [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` |
| [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` |
| [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` |
| [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` |
| [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` |



Updates `@primer/primitives` from 11.3.2 to 11.4.0
- [Release notes](https://github.com/primer/primitives/releases)
- [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md)
- [Commits](primer/primitives@v11.3.2...v11.4.0)

Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2
- [Release notes](https://github.com/primer/stylelint-config/releases)
- [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md)
- [Commits](primer/stylelint-config@v13.4.1...v13.4.2)

Updates `autoprefixer` from 10.4.23 to 10.4.24
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.23...10.4.24)

Updates `eslint` from 9.39.2 to 10.0.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.2...v10.0.0)

Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0)

Updates `globby` from 16.1.0 to 16.1.1
- [Release notes](https://github.com/sindresorhus/globby/releases)
- [Commits](sindresorhus/globby@v16.1.0...v16.1.1)

Updates `semver` from 7.7.3 to 7.7.4
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.7.3...v7.7.4)

Updates `stylelint` from 17.0.0 to 17.3.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@17.0.0...17.3.0)

---
updated-dependencies:
- dependency-name: "@primer/primitives"
  dependency-version: 11.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@primer/stylelint-config"
  dependency-version: 13.4.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: autoprefixer
  dependency-version: 10.4.24
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: eslint
  dependency-version: 10.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-jest
  dependency-version: 29.15.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: globby
  dependency-version: 16.1.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: semver
  dependency-version: 7.7.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: stylelint
  dependency-version: 17.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix failing stylelint CI workflow (#2988)

* Bump the all group across 1 directory with 8 updates

Bumps the all group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [@primer/primitives](https://github.com/primer/primitives) | `11.3.2` | `11.4.0` |
| [@primer/stylelint-config](https://github.com/primer/stylelint-config) | `13.4.1` | `13.4.2` |
| [autoprefixer](https://github.com/postcss/autoprefixer) | `10.4.23` | `10.4.24` |
| [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.0.0` |
| [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `29.12.1` | `29.15.0` |
| [globby](https://github.com/sindresorhus/globby) | `16.1.0` | `16.1.1` |
| [semver](https://github.com/npm/node-semver) | `7.7.3` | `7.7.4` |
| [stylelint](https://github.com/stylelint/stylelint) | `17.0.0` | `17.3.0` |



Updates `@primer/primitives` from 11.3.2 to 11.4.0
- [Release notes](https://github.com/primer/primitives/releases)
- [Changelog](https://github.com/primer/primitives/blob/main/CHANGELOG.md)
- [Commits](primer/primitives@v11.3.2...v11.4.0)

Updates `@primer/stylelint-config` from 13.4.1 to 13.4.2
- [Release notes](https://github.com/primer/stylelint-config/releases)
- [Changelog](https://github.com/primer/stylelint-config/blob/main/CHANGELOG.md)
- [Commits](primer/stylelint-config@v13.4.1...v13.4.2)

Updates `autoprefixer` from 10.4.23 to 10.4.24
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.23...10.4.24)

Updates `eslint` from 9.39.2 to 10.0.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.2...v10.0.0)

Updates `eslint-plugin-jest` from 29.12.1 to 29.15.0
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v29.12.1...v29.15.0)

Updates `globby` from 16.1.0 to 16.1.1
- [Release notes](https://github.com/sindresorhus/globby/releases)
- [Commits](sindresorhus/globby@v16.1.0...v16.1.1)

Updates `semver` from 7.7.3 to 7.7.4
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.7.3...v7.7.4)

Updates `stylelint` from 17.0.0 to 17.3.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@17.0.0...17.3.0)

---
updated-dependencies:
- dependency-name: "@primer/primitives"
  dependency-version: 11.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: "@primer/stylelint-config"
  dependency-version: 13.4.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: autoprefixer
  dependency-version: 10.4.24
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: eslint
  dependency-version: 10.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: eslint-plugin-jest
  dependency-version: 29.15.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: globby
  dependency-version: 16.1.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: semver
  dependency-version: 7.7.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: stylelint
  dependency-version: 17.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>

* Initial plan

* Fix all stylelint errors causing CI workflow failure

Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

* Fix stylelint CI failure caused by missing `balanced-match` dependency (#2989)

* Initial plan

* Fix stylelint CI failure: update package-lock.json to use stylelint@17.4.0

Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Brittany L. Houtz <55068883+llastflowers@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Brittany L. Houtz <55068883+llastflowers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants