Fix Storybook build: remove invalid positional argument in build-storybook script#3004
Merged
llastflowers merged 6 commits intodependabot/npm_and_yarn/docs/multi-15a9fc0651from Mar 12, 2026
Conversation
Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core). These dependencies need to be updated together. Removes `tar` Updates `storybook` from 7.6.21 to 10.2.17 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v10.2.17/code/core) --- updated-dependencies: - dependency-name: tar dependency-version: dependency-type: indirect - dependency-name: storybook dependency-version: 10.2.17 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [66657338185] Fix failing GitHub Actions workflow
Fix Storybook build: remove invalid positional argument in build-storybook script
Mar 12, 2026
680b28d to
784dce7
Compare
* Initial plan
* Fix ESM compatibility: replace require('sass') with ESM import in main.js
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
* Fix Storybook 10 build: complete v7→v10 migration (#3007)
* Initial plan
* Initial plan for fixing storybook build failures
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
* Fix Storybook 10 build: update packages, add SCSS/Babel/docs support, fix compat shims
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
* Address code review: remove unused assert dep, rename config var, clean up shim script
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
* Fix docs npm install failure due to storybook peer dependency conflicts (#3008)
* Initial plan
* fix: resolve storybook peer dependency conflicts in docs install
- Update @geometricpanda/storybook-addon-badges to ^2.0.5 which supports @storybook/blocks@^8.3.0 (v2.0.0 only supported ^7.0.0)
- Add docs/.npmrc with legacy-peer-deps=true to handle the intentional mixed storybook 8/10 package setup used by shims and webpack aliases
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
…ilot/fix-github-actions-workflow-another-one
llastflowers
approved these changes
Mar 12, 2026
…t found (#3009) * Initial plan * fix: regenerate docs/package-lock.json to fix storybook binary not found Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: llastflowers <55068883+llastflowers@users.noreply.github.com>
llastflowers
approved these changes
Mar 12, 2026
d12dd66
into
dependabot/npm_and_yarn/docs/multi-15a9fc0651
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook 10 dropped support for positional arguments in the
buildcommand. Thedocs/script/build-storybookscript was passingpublic/staticas a positional arg, causing the Deploy Preview CI job to fail with:What are you trying to accomplish?
Fix the failing "Deploy preview / Build" GitHub Actions job caused by an incompatible
storybook buildinvocation.What approach did you choose and why?
Remove the
public/staticpositional argument from thestorybook buildinvocation indocs/script/build-storybook. The static directory is already declared in.storybook/main.jsviastaticDirs: ['../stories/static']— the CLI argument was redundant and is no longer accepted in Storybook 10.What should reviewers focus on?
Confirm that the static assets previously served from
public/staticare correctly covered by thestaticDirsconfig in.storybook/main.js.Can these changes ship as is?
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.