Allow custom commit message and pull request title#12
Allow custom commit message and pull request title#12saadmk11 merged 6 commits intosaadmk11:mainfrom itsMaxC:main
Conversation
saadmk11
left a comment
There was a problem hiding this comment.
Hi @thehedgefrog, Thanks for The PR! 💯
| commit_message = os.environ['INPUT_COMMIT_MESSAGE'] | ||
| # Pull Request Title | ||
| pr_title = os.environ['INPUT_PULL_REQUEST_TITLE'] |
There was a problem hiding this comment.
I think we should pass these to the GitHubActionsVersionUpdater classes __init__() method, just like ignore input.
There was a problem hiding this comment.
I am very much a newbie with Python, I will look into this and figure it out :)
There was a problem hiding this comment.
Hi @saadmk11 - added it but I am not sure it was in the spirit of your suggestion. Let me know and thank you!
|
@saadmk11 following up to see if there are more corrections to be made :) |
saadmk11
left a comment
There was a problem hiding this comment.
Hey @thehedgefrog, I have suggested a few small changes so that we can run the GitHubActionsVersionUpdater without needing the user inputs.
Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
|
@saadmk11 thank you so much for this, it's very helpful for my understanding of Python! Also, I caught how my testing was not complete. Cheers! |
Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
saadmk11
left a comment
There was a problem hiding this comment.
Thanks for addressing the change request. This looks great! 🚀
This PR creates two new inputs, to allow customizing the PR title and commit message. This is useful when someone wants to ensure consistency in their repo, such as using conventional commits or any organization standard.
Those are optional, and will default to the current value of 'Update GitHub Action Versions'.
New inputs were also documented in the README file.