-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(knowledge): add embedding model selection and Cohere reranker #4349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9614a28
feat(knowledge): add embedding model selection and Cohere reranker
waleedlatif1 c56b7a4
fix(knowledge): split reranker model constants into client-safe module
waleedlatif1 5d1446f
fix(knowledge): bill rerank on every successful API call and fix MDX …
waleedlatif1 553021a
test(knowledge): align embedding tests with provider abstraction changes
waleedlatif1 542d2ed
fix(knowledge): require explicit Azure deployment per OpenAI embeddin…
waleedlatif1 d70ac8f
fix(knowledge): skip platform reranker billing for BYOK Cohere keys
waleedlatif1 57589cb
fix(knowledge): match search tokenizer to embedding provider; remove …
waleedlatif1 96cf4dd
fix(knowledge): match chunk tokenizer to KB embedding provider
waleedlatif1 14538a1
refactor(knowledge): centralize tokenizer mapping on EmbeddingModelInfo
waleedlatif1 7a9ba8b
refactor(knowledge): lock embedding model to KB_EMBEDDING_MODEL env var
waleedlatif1 53624f3
fix(knowledge): use provider tokenizer for chunks and bound rerank in…
waleedlatif1 97fa4d5
fix(knowledge): use .count from estimateTokenCount return value
waleedlatif1 b1643ee
fix(knowledge): only enforce single embedding model when query is pre…
waleedlatif1 78d6af7
fix(knowledge): use getConfiguredEmbeddingModel in copilot KB creation
waleedlatif1 687b7f5
fix(knowledge): make EMBEDDING_DIMENSIONS a literal type
waleedlatif1 f7eef61
fix(knowledge): use per-KB embedding model in v1 search route
waleedlatif1 cb1cab7
chore(knowledge): polish embedding/reranker implementation
waleedlatif1 5dfaed2
fix(knowledge): resolve type errors and unhandled rejection in search…
waleedlatif1 b73c218
fix(knowledge): pass Gemini API key via x-goog-api-key header
waleedlatif1 64a17db
fix(knowledge): default Azure deployment name to embedding model name
waleedlatif1 99743d9
fix(knowledge): cap Gemini batches at 100 items, add singular GEMINI_…
waleedlatif1 8fd0557
fix(knowledge): prefer singular Cohere key before rotation
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.