spec: Add edit and open config actions for file-based MCP servers#9884
spec: Add edit and open config actions for file-based MCP servers#9884oz-for-oss[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Varoon Kodithala <116049637+vkodithala@users.noreply.github.com>
|
@oz-for-oss[bot] I'm starting a first review of this spec-only pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds product and tech specs for opening backing config files from file-based MCP server cards. The specs cover the user-facing behavior, routing plan, resolver shape, validation, and non-local build constraints.
Concerns
- The tech spec's global Warp root assumption conflicts with the current managed MCP path helper, which can lead implementation and tests to validate the wrong stored root for global Warp configs.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - Convert each `(root_path, provider)` pair to the same concrete config path that `FileMCPWatcher` scans: | ||
| - For project roots, use `root_path.join(provider.project_config_path())`. | ||
| - For non-Warp global roots, use `root_path.join(provider.home_config_path())`. | ||
| - For global Warp, use `warp_core::paths::warp_home_mcp_config_file_path()` or the same path exposed by `warp_managed_mcp_config_path()`, not `root_path.join(provider.home_config_path())`, because the stored root is Warp's data directory rather than the home directory. |
There was a problem hiding this comment.
warp_managed_mcp_config_path() stores root_path as the home directory, not Warp's data directory, so this resolver/test plan can exercise a different key from runtime global Warp discovery. Specify which root key is canonical and add coverage for the actual managed MCP path before implementation.
Summary
Related issue: #9882
Validation
Conversation: https://app.warp.dev/conversation/484c90f0-c999-4d86-b74d-ced0ae637456
Run: https://oz.warp.dev/runs/019de6b0-ba76-70f1-ada2-800b5b937252
This PR was generated with Oz.