Skip to content

Fix for Intel QuickAssist RSA Key generation exponent result #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobBarthelmeh merged 1 commit into from
Oct 29, 2024
Merged

Fix for Intel QuickAssist RSA Key generation exponent result #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wolfcrypt/src/port/intel/quickassist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1235,7 +1235,7 @@ static void IntelQaRsaKeyGenCallback(void *pCallbackTag,
RsaKey* key = dev->qat.op.rsa_keygen.rsakey;
if (key) {
/* Populate RsaKey Parameters */
/* raw BigInt buffer ownership is transfered to RsaKey */
/* raw BigInt buffer ownership is transferred to RsaKey */
/* cleanup is handled in wc_FreeRsaKey */

/* modulusN */
Expand Down Expand Up @@ -1280,15 +1280,15 @@ static void IntelQaRsaKeyGenCallback(void *pCallbackTag,
/* exponent1Dp */
if (ret == 0)
ret = IntelQaFlatBufferToBigInt(
&pPrivateKey->privateKeyRep2.exponent2Dq, &key->dP.raw);
&pPrivateKey->privateKeyRep2.exponent1Dp, &key->dP.raw);
if (ret == 0)
ret = mp_read_unsigned_bin(&key->dP,
key->dP.raw.buf, key->dP.raw.len);

/* exponent2Dq */
if (ret == 0)
ret = IntelQaFlatBufferToBigInt(
&pPrivateKey->privateKeyRep2.exponent1Dp, &key->dQ.raw);
&pPrivateKey->privateKeyRep2.exponent2Dq, &key->dQ.raw);
if (ret == 0)
ret = mp_read_unsigned_bin(&key->dQ,
key->dQ.raw.buf, key->dQ.raw.len);
Expand Down
2 changes: 1 addition & 1 deletion wolfssl/wolfcrypt/port/intel/quickassist.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ typedef void (*IntelQaFreeFunc)(struct WC_ASYNC_DEV*);

/* QuickAssist device */
typedef struct IntelQaDev {
CpaInstanceHandle handle;
CpaInstanceHandle handle;
int devId;

/* callback return info */
Expand Down