Skip to content

Correct kyber levels. Was copy and paste error.#8084

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
anhu:kyber_levels
Oct 16, 2024
Merged

Correct kyber levels. Was copy and paste error.#8084
douzzer merged 1 commit intowolfSSL:masterfrom
anhu:kyber_levels

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Oct 16, 2024

No description provided.

Copy link
Copy Markdown
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRB-liboqs.txt_0 isn't getting along with the changes:

Testing configuration:
--with-liboqs --enable-experimental  --enable-opensslextra
Testing DEFAULT: --with-liboqs --enable-experimental  --enable-opensslextra
Configure RESULT = 0
make[2]: warning: -j3 forced in submake: resetting jobserver mode.
src/ssl.c:21837:66: error: ‘WOLFSSL_P256_KYBER_LEVEL3’ undeclared here (not in a function); did you mean ‘WOLFSSL_P256_KYBER_LEVEL1’?
21837 |     {CURVE_NAME("P384_KYBER_LEVEL3"), WOLFSSL_P384_KYBER_LEVEL3, WOLFSSL_P256_KYBER_LEVEL3},
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  WOLFSSL_P256_KYBER_LEVEL1
src/ssl.c:21837:5: error: missing initializer for field ‘curve’ of ‘WOLF_EC_NIST_NAME’ [-Werror=missing-field-initializers]
21837 |     {CURVE_NAME("P384_KYBER_LEVEL3"), WOLFSSL_P384_KYBER_LEVEL3, WOLFSSL_P256_KYBER_LEVEL3},
      |     ^
In file included from src/ssl.c:[36](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-36):
./wolfssl/internal.h:6398:12: note: ‘curve’ declared here
 6398 |     word16 curve;
      |            ^~~~~
src/ssl.c:21838:66: error: ‘WOLFSSL_P256_KYBER_LEVEL5’ undeclared here (not in a function); did you mean ‘WOLFSSL_P256_KYBER_LEVEL1’?
218[38](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-38) |     {CURVE_NAME("P521_KYBER_LEVEL5"), WOLFSSL_P521_KYBER_LEVEL5, WOLFSSL_P256_KYBER_LEVEL5},
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  WOLFSSL_P256_KYBER_LEVEL1
src/ssl.c:21838:5: error: missing initializer for field ‘curve’ of ‘WOLF_EC_NIST_NAME’ [-Werror=missing-field-initializers]
21838 |     {CURVE_NAME("P521_KYBER_LEVEL5"), WOLFSSL_P521_KYBER_LEVEL5, WOLFSSL_P256_KYBER_LEVEL5},
      |     ^
In file included from src/ssl.c:36:
./wolfssl/internal.h:6[39](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-39)8:12: note: ‘curve’ declared here
 6398 |     word16 curve;
      |            ^~~~~

@douzzer douzzer assigned anhu and unassigned wolfSSL-Bot Oct 16, 2024
@anhu anhu requested a review from douzzer October 16, 2024 17:41
@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Oct 16, 2024

retest this please

@anhu anhu assigned wolfSSL-Bot and unassigned anhu Oct 16, 2024
@douzzer douzzer merged commit a833d6e into wolfSSL:master Oct 16, 2024
kp-max-li added a commit to expressvpn/wolfssl-rs that referenced this pull request Oct 28, 2024
kp-thomas-yau pushed a commit to expressvpn/wolfssl-rs that referenced this pull request Oct 29, 2024
@anhu anhu deleted the kyber_levels branch March 24, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants