Merged
Conversation
GSK-1745 Upgrade pydantic to 2.0+
Several users have faced dependency issues because of our strict requirement for pydantic versions. Need to investigate what it takes to do this. Possible issue: libraries we rely on might still rely on older versions of pydantic |
83d7469 to
9e870db
Compare
8fd1ae6 to
df20765
Compare
Inokinoki
reviewed
Sep 22, 2023
Inokinoki
reviewed
Sep 22, 2023
Inokinoki
reviewed
Sep 22, 2023
Inokinoki
reviewed
Sep 22, 2023
Inokinoki
reviewed
Sep 22, 2023
Inokinoki
requested changes
Sep 22, 2023
Hartorn
commented
Sep 22, 2023
Hartorn
commented
Sep 22, 2023
Hartorn
commented
Sep 22, 2023
Co-authored-by: Inoki <weixuan@giskard.ai>
15f418b to
c467382
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Inokinoki
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Major issues encountered :
Everything else is only minor changes to enforce types and respect pydantic validation