Skip to content

[GSK-2497] Allow to connect multiple external mlworkers#1740

Merged
Hartorn merged 8 commits intomulti-ml-workerfrom
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers
Jan 29, 2024
Merged

[GSK-2497] Allow to connect multiple external mlworkers#1740
Hartorn merged 8 commits intomulti-ml-workerfrom
feature/gsk-2497-allow-to-connect-multiple-external-mlworkers

Conversation

@Hartorn
Copy link
Copy Markdown
Member

@Hartorn Hartorn commented Jan 17, 2024

See also https://github.com/Giskard-AI/giskard-hub/pull/399

TODO:

  • reworking the cli worker (restart, stop command)
  •  re word the error message in cli worker

@Hartorn Hartorn requested a review from Inokinoki January 17, 2024 11:44
@Hartorn Hartorn self-assigned this Jan 17, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Jan 17, 2024

@Hartorn Hartorn changed the title Feature/gsk 2497 allow to connect multiple external mlworkers [GSK-2497] Allow to connect multiple external mlworkers Jan 17, 2024
@Hartorn Hartorn force-pushed the feature/gsk-2497-allow-to-connect-multiple-external-mlworkers branch from 12f3623 to 7950cbf Compare January 18, 2024 14:19
@Hartorn Hartorn marked this pull request as ready for review January 19, 2024 13:45
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions

18.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link
Copy Markdown
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread giskard/cli_utils.py
def tail(filename, n=100):
"""Return the last n lines of a file"""
return collections.deque(open(filename), n)
with Path(filename).open("r", encoding="utf-8") as fp:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice capture!

@Hartorn Hartorn merged commit 1a90df7 into multi-ml-worker Jan 29, 2024
@Hartorn Hartorn deleted the feature/gsk-2497-allow-to-connect-multiple-external-mlworkers branch January 29, 2024 09:00
andreybavt added a commit that referenced this pull request Apr 7, 2024
[GSK-2497] Allow to connect multiple external mlworkers (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants