Skip to content

[GSK-2497] Allow to connect multiple external mlworkers (#1740)#1771

Merged
andreybavt merged 62 commits intomainfrom
multi-ml-worker
Apr 7, 2024
Merged

[GSK-2497] Allow to connect multiple external mlworkers (#1740)#1771
andreybavt merged 62 commits intomainfrom
multi-ml-worker

Conversation

@Hartorn
Copy link
Copy Markdown
Member

@Hartorn Hartorn commented Jan 29, 2024

Main branch for multiple ml workers (not yet to be merged)

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn
[GSK-2497] Allow to connect multiple external mlworkers (#1740)
1a90df7 
* WIP

* Removing notion of internal and external

* Fix raised error in CLI

* Fixing lint + fixing tests

* Fix cli for worker

* Fix linting

* Fixing communications tests
@Hartorn Hartorn self-assigned this Jan 29, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Jan 29, 2024

GSK-2497 Allow to connect multiple external mlworkers

Hartorn and others added 10 commits January 29, 2024 10:01
@Hartorn
Merge branch 'main' into multi-ml-worker
70962bd
@Hartorn
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
04c3340 
…rker
@Hartorn
Merge branch 'main' into multi-ml-worker
1879a5c
@Hartorn
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
9dd490a 
…rker
@Hartorn
Merge branch 'main' into multi-ml-worker
472040c
@Hartorn
Merge branch 'main' into multi-ml-worker
43e132e
@Hartorn
Switching from mlWorkerId to kernel name (#1777)
8403f75 
* Switching from mlWorkerId to kernel name

* Regenerating pdm.lock

* Fixing a test

* Regenerating pdm.lock

* Fixing tests

* Regenerating pdm.lock

---------

Co-authored-by: BotLocker <bot.locker@users.noreply.github.com>
@Hartorn
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
131eefe 
…rker
@Hartorn
Merge branch 'main' into multi-ml-worker
ec12a20
@Hartorn
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
b0fb46f 
…rker
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 5, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Mar 5, 2024
Inokinoki and others added 12 commits March 6, 2024 13:35
@Inokinoki
Add start kernel and stop kernel in Giskard Client
2f237d1
@Inokinoki
Allow to start, stop and restart workers on server side
cbd3632
@henchaves
Merge branch 'main' into multi-ml-worker
551de09
@kevinmessiaen
GSK-2887 Upload tests with project when uploading a suite
ce94397
@kevinmessiaen
GSK-2887 Upload tests with project when uploading a suite
2a14d75
@kevinmessiaen
Merge branch 'multi-ml-worker' into GSK-2887
a9e4798 
# Conflicts:
#	giskard/core/suite.py
@kevinmessiaen
GSK-2887 Fixed tests
31ebdbb
@kevinmessiaen
GSK-2887 Fixed tests
fb74cfd
@kevinmessiaen
GSK-2887 Fixed tests
140b9a1
@kevinmessiaen @Hartorn
GSK-2896 Automatically generate a Kernel based on dependencies (#1829)
71e5369 
* GSK-2896 Auto mode for kernel is a need

* GSK-2896 Auto mode for kernel is a need

* GSK-2875 Make kernel name related to project

* GSK-2896 Extracted `create_kernel` method

---------

Co-authored-by: Hartorn <bazire@giskard.ai>
@kevinmessiaen
GSK-2887 Comment clean up
253b067
@kevinmessiaen
GSK-2887 Removing client dependency
7709a4c
Inokinoki and others added 10 commits March 22, 2024 16:17
@Inokinoki
Fix links in install hfs and on prem
bb942d0
@Inokinoki
Add descriptions of managed/unmanaged ML worker
28e4595
@Inokinoki
Merge branch 'main' of github.com:Giskard-AI/giskard into doc/gsk-287…
24dba45 
…7-handle-kernel-migration-for-existing-projects
@Inokinoki
Merge branch 'multi-ml-worker' of github.com:Giskard-AI/giskard into …
10c9af8 
…doc/gsk-2877-handle-kernel-migration-for-existing-projects
@Inokinoki
Add examples for (un)managed kernels and ML workers
7adbfcf
@andreybavt
added dev mode tools
8522a5f
@Inokinoki
Merge branch 'multi-ml-worker' into doc/gsk-2877-handle-kernel-migrat…
bbf0ee7 
…ion-for-existing-projects
@Inokinoki
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
42fe96f 
…rker
@Inokinoki
Merge branch 'multi-ml-worker' into doc/gsk-2877-handle-kernel-migrat…
cc0df68 
…ion-for-existing-projects
@Hartorn
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
268c46a 
…rker
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
Inokinoki and others added 11 commits April 2, 2024 17:20
@Inokinoki
Merge branch 'multi-ml-worker' into doc/gsk-2877-handle-kernel-migrat…
39315bb 
…ion-for-existing-projects
@henchaves
Add telemetry to kernel/worker client methods
b17422f
@Inokinoki
Merge branch 'main' of github.com:Giskard-AI/giskard into multi-ml-wo…
ce086fc 
…rker
@henchaves
Merge branch 'multi-ml-worker' into feature/gsk-3419-add-mixpanel-tel…
7227e50 
…emetry
@henchaves
Update analytics event for initialize_kernel
58f51b1
@henchaves
Merge pull request #1875 from Giskard-AI/feature/gsk-3419-add-mixpane…
1c79757 
…l-telemetry

[GSK-3419] Add mixpanel telemetry to new client methods
@andreybavt
do not fail with exception when log file doesn't exist yet
f45d2d1
@Inokinoki @kevinmessiaen
[GSK-3430] Detect the version of giskard library with extras such as …
af17630 
…[hub, llm] (#1876)

* Add `exact_deps` parameter to allow extract deps with extras (always on for giskard)

* Add excluded libs for `pip` and `setuptools` (user-definable)

* Fix var name for `requested_dependencies`

---------

Co-authored-by: Kevin Messiaen <114553769+kevinmessiaen@users.noreply.github.com>
@Inokinoki
Make constants for all env detections
204e2e9
@Inokinoki
Add only_giskard and enable it for Colab
c243f66
@andreybavt
Merge pull request #1879 from Giskard-AI/feature/gsk-3442-install-gis…
4c1faa8 
…kard-only-on-google-colab-and-the-other-cloud

[GSK-3442] Install giskard only on google colab
@andreybavt andreybavt marked this pull request as ready for review April 5, 2024 14:43
@andreybavt
docs rewording
e15a717
@andreybavt
Merge pull request #1853 from Giskard-AI/doc/gsk-2877-handle-kernel-m…
f2b7c9f 
…igration-for-existing-projects

[GSK-2877] Update doc about ML worker to adapt kernel and multi-ML worker
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@andreybavt andreybavt merged commit 1f8da90 into main Apr 7, 2024
@andreybavt andreybavt deleted the multi-ml-worker branch April 7, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Googleton Googleton Awaiting requested review from Googleton

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hartorn @andreybavt @Inokinoki @henchaves @kevinmessiaen