Skip to content

[GSK-2625] Fix deprecations in tests fixtures from sklearn 1.4.0 #1743

Merged
Hartorn merged 23 commits intomainfrom
GSK-2625
Feb 1, 2024
Merged

[GSK-2625] Fix deprecations in tests fixtures from sklearn 1.4.0 #1743
Hartorn merged 23 commits intomainfrom
GSK-2625

Conversation

@andreybavt
Copy link
Copy Markdown
Contributor

@andreybavt andreybavt commented Jan 18, 2024

No description provided.

@andreybavt andreybavt added the Lockfile Temporary label to update pdm.lock label Jan 18, 2024
@andreybavt andreybavt requested a review from mattbit January 18, 2024 14:03
@linear
Copy link
Copy Markdown

linear Bot commented Jan 18, 2024

GSK-2625 Check compatibility of `giskard` with scikit-learn==1.4.0

@mattbit mattbit changed the title Gsk 2625 Fix deprecations in tests fixtures from sklearn 1.4.0 [GSK-2625] Jan 18, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Jan 18, 2024
@andreybavt andreybavt enabled auto-merge January 18, 2024 14:08
@mattbit mattbit added the Lockfile Temporary label to update pdm.lock label Jan 18, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Jan 18, 2024
@mattbit
Copy link
Copy Markdown
Member

mattbit commented Jan 19, 2024

Little problems with our test fixtures:

  • Compatibility problem with imbalanced learn which we use in one fixture (new release should be out soon, see Compatibility with scikit-learn 1.4.0 scikit-learn-contrib/imbalanced-learn#1057)
  • Updated the lbfgs solver causes some very little modifications of the fitted coefficients, in one case this affected our tests (one more reason to save the trained models as fixtures instead of rerunning the full training for each build…)

Nothing affecting the library from what I see.

@mattbit
Copy link
Copy Markdown
Member

mattbit commented Jan 26, 2024

Updated version of imbalanced-learn is now released:
https://github.com/scikit-learn-contrib/imbalanced-learn/releases/tag/0.12.0

Will re-enable our previously broken fixture

@mattbit mattbit added the Lockfile Temporary label to update pdm.lock label Jan 26, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Jan 26, 2024
@Hartorn Hartorn disabled auto-merge January 29, 2024 09:06
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Feb 1, 2024
@Hartorn Hartorn changed the title Fix deprecations in tests fixtures from sklearn 1.4.0 [GSK-2625] [GSK-2625] Fix deprecations in tests fixtures from sklearn 1.4.0 Feb 1, 2024
@andreybavt andreybavt requested a review from a team February 1, 2024 13:49
@Hartorn Hartorn force-pushed the GSK-2625 branch 3 times, most recently from dfb33df to 6a94b36 Compare February 1, 2024 14:31
@Hartorn Hartorn force-pushed the GSK-2625 branch 10 times, most recently from c20ef23 to 611f332 Compare February 1, 2024 15:43
@Hartorn Hartorn enabled auto-merge (squash) February 1, 2024 15:44
@Hartorn Hartorn mentioned this pull request Feb 1, 2024
Closed
11 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Hartorn Hartorn merged commit 3e84184 into main Feb 1, 2024
@Hartorn Hartorn deleted the GSK-2625 branch February 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hartorn Hartorn Hartorn approved these changes

@mattbit mattbit Awaiting requested review from mattbit

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreybavt @mattbit @Hartorn